Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added series styling to more parts of the app #166

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Added series styling to more parts of the app #166

merged 2 commits into from
Feb 14, 2024

Conversation

vinnyjth
Copy link
Member

🐛 Issue

https://3.basecamp.com/3926363/buckets/32694519/card_tables/cards/7067994581

https://3.basecamp.com/3926363/buckets/32694519/card_tables/cards/7068020702

✏️ Solution

  • Add the "series" tag to additional feature feed rendering paths
  • Add the series tag to HeroListFeatures

🔬 To Test

All in web-embeds

Visit Here for feature feed changes.

Add this HTML to the index.html for hero feature changes.


  <div data-type="FeatureFeed" data-church="liquid_church"
    data-feature-feed="FeatureFeed:04160599-4edf-4824-98c5-02c1a8854c48"
    data-placeholder="Life Is Hard. How Can We Help?" data-modal="true" class="apollos-widget"></div>

📸 Screenshots

CleanShot 2024-02-13 at 13 42 43@2x CleanShot 2024-02-13 at 13 41 04@2x CleanShot 2024-02-13 at 13 33 59@2x CleanShot 2024-02-13 at 13 33 55@2x

@vercel Vercel
Copy link

vercel bot commented Feb 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apollos-micro-service ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 6:48pm
apollos-web-embeds ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 6:48pm

@vinnyjth vinnyjth requested a review from nlewis84 February 14, 2024 01:54
nlewis84
nlewis84 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@nlewis84 nlewis84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

packages/web-shared/components/FeatureFeed/Features/HeroListFeature.js
@@ -20,7 +20,7 @@ function HeroListFeature(props = {}) {
if (item.action === 'OPEN_URL') {
analytics.track('OpenUrl', {
url: item?.relatedNode?.url,
});
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good linter

@nlewis84 nlewis84 merged commit d1f56a0 into main Feb 14, 2024
5 checks passed
@nlewis84 nlewis84 deleted the more-series-styling branch February 14, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewis84 nlewis84 nlewis84 approved these changes

Assignees

@nlewis84 nlewis84

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinnyjth @nlewis84